Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data source for Service API #118

Merged
merged 13 commits into from
Jul 8, 2020
Merged

Data source for Service API #118

merged 13 commits into from
Jul 8, 2020

Conversation

msg4sunny
Copy link
Contributor

Adding data source for Service API

@ghost ghost added the size/M label Jul 1, 2020
ffahri
ffahri suggested changes Jul 1, 2020
View reviewed changes
Copy link

@ffahri ffahri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we need documentation for this, you can find examples in website/ folder

opsgenie/data_source_opsgenie_service.go Outdated Show resolved Hide resolved
opsgenie/data_source_opsgenie_service_test.go Outdated Show resolved Hide resolved
opsgenie/data_source_opsgenie_service_test.go Outdated Show resolved Hide resolved
opsgenie/data_source_opsgenie_service.go Show resolved Hide resolved
opsgenie/data_source_opsgenie_service_test.go Show resolved Hide resolved
@ghost ghost added size/L and removed size/M labels Jul 1, 2020
ffahri
ffahri suggested changes Jul 1, 2020
View reviewed changes
opsgenie/data_source_opsgenie_service.go Outdated Show resolved Hide resolved
opsgenie/data_source_opsgenie_service_test.go Outdated Show resolved Hide resolved
ffahri
ffahri suggested changes Jul 1, 2020
View reviewed changes
Copy link

@ffahri ffahri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add documentation to this implementation, examples can be found in website/ folder in the root of this repository

opsgenie/data_source_opsgenie_service.go Outdated Show resolved Hide resolved
opsgenie/data_source_opsgenie_service.go Outdated Show resolved Hide resolved
@ghost ghost added the documentation label Jul 1, 2020
ffahri
ffahri suggested changes Jul 1, 2020
View reviewed changes
Copy link

@ffahri ffahri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you also need to add document link to here
https://github.com/terraform-providers/terraform-provider-opsgenie/blob/master/website/opsgenie.erb

website/docs/d/service.html.markdown Outdated Show resolved Hide resolved
website/docs/d/service.html.markdown Show resolved Hide resolved
opsgenie/data_source_opsgenie_service.go Outdated Show resolved Hide resolved
@msg4sunny
Copy link
Contributor Author

you also need to add document link to here
https://github.com/terraform-providers/terraform-provider-opsgenie/blob/master/website/opsgenie.erb

Done

@ffahri ffahri self-requested a review July 3, 2020 06:59
@ffahri ffahri merged commit a2108ce into opsgenie:master Jul 8, 2020
rohit-h pushed a commit to rohit-h/terraform-provider-opsgenie that referenced this pull request Jul 13, 2020
@msg4sunny
Data source for Service API (opsgenie#118)
8405ff1 
* Added data source for Service API
cookiefission added a commit to cookiefission/terraform-provider-opsgenie that referenced this pull request Jul 20, 2020
@cookiefission
Correct resource to data in service docs
38ba7b0 
Error was introduced with the data source itself in opsgenie#118
@cookiefission cookiefission mentioned this pull request Jul 20, 2020
Merged
ffahri pushed a commit that referenced this pull request Jul 20, 2020
@cookiefission
Correct resource to data in service docs (#134)
dd77c4f 
Error was introduced with the data source itself in #118
ffahri pushed a commit that referenced this pull request Jul 20, 2020
@cookiefission
website update (#135)
90c55f3 
* Cleanup after v0.3.9 release

* Correct resource to data in service docs (#134)

Error was introduced with the data source itself in #118

Co-authored-by: tf-release-bot <terraform@hashicorp.com>
Co-authored-by: Sean Kenny <sean.kenny@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffahri ffahri ffahri approved these changes

Assignees
No one assigned
Labels
documentation size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msg4sunny @ffahri