Skip to content

Fix #6044: Make StringResourceParser depend on "alllanguages" config #6077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
ShankhanilSaha wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Fix #6044: Make StringResourceParser depend on "alllanguages" config #6077

ShankhanilSaha wants to merge 1 commit into from
+49 −32

Conversation

@ShankhanilSaha
Copy link
Member

@ShankhanilSaha ShankhanilSaha commented Jan 22, 2026

Explanation

Fixes #6044

  • Updates StringResourceParser.kt to rely on supported_languages.textproto for supported languages rather than hardcoded enum class.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

@ShankhanilSaha ShankhanilSaha requested a review from a team as a code owner January 22, 2026 10:29
@ShankhanilSaha ShankhanilSaha marked this pull request as draft January 22, 2026 13:45
@ShankhanilSaha
Update StringResourceParser.kt to automatically detect supported lang…
7819675 
…uages and not rely on a hardcoded enum field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenHenning BenHenning Awaiting requested review from BenHenning BenHenning is a code owner automatically assigned from oppia/android-dev-workflow-reviewers

At least 1 approving review is required to merge this pull request.

Assignees

@ShankhanilSaha ShankhanilSaha

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Make StringResourceParser depend on "alllanguages" config

1 participant

@ShankhanilSaha