Fix part of #5815: Add Missing Tests

[itsadityaaaaa]

Explanation

Fix part of #5815

• It includes tests for:
  • AdminstatorControlsFragmentTest
  • Portrait, Landascape & Mutipane (Analytics Disabled and Enabled)
  • AdminstartorControlsActivityTest
  • Portrait, Landscape & Multipane (Analytics Disabled and Enabled)
  • MathExpressionExtensionTest

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

• Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
• For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
• Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
• For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
• Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

[itsadityaaaaa]

@manas-yu @adhiamboperes before moving forward or commiting more test in the PR just need a small assurance on the logic and format of the tests. It will be great help.

[adhiamboperes]

Thanks @itsadityaaaaa, the tests are on the right path. Please take a look at my comments before proceeding further.

[github-actions]

Coverage Report

Results

Number of files assessed: 4
Overall Coverage: 97.50%
Coverage Analysis: PASS ✅

Passing coverage

Files with passing code coverage

File	Coverage	Lines Hit	Status	Min Required
MathExpressionExtensions.kt utility/src/main/java/org/oppia/android/util/math/MathExpressionExtensions.kt	97.50%	39 / 40	✅	42% *

* represents tests with custom overridden pass/fail coverage thresholds

Exempted coverage

Files exempted from coverage

File	Exemption Reason
AdministratorControlsActivity.kt app/src/main/java/org/oppia/android/app/administratorcontrols/AdministratorControlsActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
AdministratorControlsFragment.kt app/src/main/java/org/oppia/android/app/administratorcontrols/AdministratorControlsFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
AdministratorControlsFragmentTestActivity.kt app/src/main/java/org/oppia/android/app/testing/AdministratorControlsFragmentTestActivity.kt	This file is exempted from having a test file; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

[itsadityaaaaa]

@adhiamboperes I have applied the suggested changes please take a look, and tell me if anything else required. If all this seems ok should I consider opening a new PR for other tests?

[oppiabot]

Unassigning @itsadityaaaaa since a re-review was requested. @itsadityaaaaa, please make sure you have addressed all review comments. Thanks!

[adhiamboperes]

This is excellent, Thanks @itsadityaaaaa! LGTM.

[oppiabot]

Unassigning @adhiamboperes since they have already approved the PR.

[oppiabot]

Assigning @manas-yu for code owner reviews. Thanks!

[adhiamboperes]

Just to verify, are these needed for tests to run?

[adhiamboperes]

@adhiamboperes I have applied the suggested changes please take a look, and tell me if anything else required. If all this seems ok should I consider opening a new PR for other tests?

You can open other PRs.