Skip to content

Fix #1625, #1626: Revert "Fix #171: Introduce support for diffing subsets of data in generic RecyclerView adapter" #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BenHenning merged 1 commit into from
Aug 12, 2020
Merged

Fix #1625, #1626: Revert "Fix #171: Introduce support for diffing subsets of data in generic RecyclerView adapter" #1627

BenHenning merged 1 commit into from
Aug 12, 2020

Conversation

@BenHenning
Copy link
Member

@BenHenning BenHenning commented Aug 12, 2020

Reverts #1359.

Fixes #1625.
Fixes #1626.

@BenHenning
Revert "Fix #171: Introduce support for diffing subsets of data in ge…
4481bba 
…neric RecyclerView adapter (#1359)"

This reverts commit 5532009.
@aggarwalpulkit596 aggarwalpulkit596 self-requested a review August 12, 2020 05:35
@BenHenning
Copy link
Member Author

BenHenning commented Aug 12, 2020

Thanks @aggarwalpulkit596! Will merge once checks are passing.

@BenHenning
Copy link
Member Author

BenHenning commented Aug 12, 2020

CI failure for utility tests:

org.oppia.util.data.DataProvidersTest > testCombineAsync_combineFuncBlocked_resumedAfterRegistration_deliversValue FAILED
    org.apache.tools.ant.BuildException
        Caused by: org.apache.maven.artifact.resolver.MultipleArtifactsNotFoundException

Seems like an unrelated flake. Re-running.

@BenHenning BenHenning merged commit de7487a into develop Aug 12, 2020
@BenHenning BenHenning deleted the revert-1359-introduce-diffing-generic-recyclerview branch August 12, 2020 06:04
This was referenced Aug 12, 2020
Closed
Open
@anandwana001
Copy link
Contributor

anandwana001 commented Aug 12, 2020 •
edited
Loading

@BenHenning @aggarwalpulkit596 link button in drag and drop not working here, just checked.

@adhiamboperes adhiamboperes mentioned this pull request Jan 19, 2026
Draft
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anandwana001 anandwana001 Awaiting requested review from anandwana001

1 more reviewer

@aggarwalpulkit596 aggarwalpulkit596 aggarwalpulkit596 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anandwana001 anandwana001

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drag & drop interaction is broken Exploration player is quite slow

4 participants

@BenHenning @anandwana001 @aggarwalpulkit596