fix: enable skipToken for better typescript handling for disabled useQueries#3075
Merged
fix: enable skipToken for better typescript handling for disabled useQueries#3075
Conversation
LMayTNG
force-pushed
the
fix/add-skip-token
branch
from
e3e6fc2 to
164e74f
Compare
src/Frontend/util/backendClient.ts
Outdated
Contributor
There was a problem hiding this comment.
would it make sense to add the database initialize to the skiptoken above or to add the skiptoken to the enabled here?
Contributor
There was a problem hiding this comment.
could make the logic cleaner, since the whole
if (options !== undefined && 'enabled' in options) {
return Boolean(
typeof options.enabled === 'function'
? options.enabled(query)
: options.enabled,
);
Ist quite bad
Contributor
Author
There was a problem hiding this comment.
Good idea, that's much cleaner
| attributionUuid: packageInfo.originalAttributionId as string, | ||
| }, | ||
| { enabled: !!packageInfo.originalAttributionId }, | ||
| packageInfo.originalAttributionId !== undefined |
Contributor
There was a problem hiding this comment.
Nit: in all other places you replace !!packageInfo.originalAttributionId with packageInfo.originalAttributionId ? ... : skipToken, instead of an undefined check
mariusAsaTNG
approved these changes
Mar 25, 2026
Signed-off-by: Leon May <leon.may@tngtech.com>
LMayTNG
force-pushed
the
fix/add-skip-token
branch
from
164e74f to
d4c5398
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.