net/frr: Move implicit BGP address family neighbor configuration to explicit dropdown - #5648
Open
Monviech wants to merge 1 commit into
Open
net/frr: Move implicit BGP address family neighbor configuration to explicit dropdown#5648Monviech wants to merge 1 commit into
Monviech wants to merge 1 commit into
Conversation
… Multi-Protocol toggle, making it inline with what peergroups offer
Member
Author
|
Migration tested: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important notices
Before you submit a pull request, we ask you kindly to acknowledge the following:
If AI was used, please disclose:
Describe the problem
Further cleanup in BGP around the address families concept.
Describe the proposed solution
Now you can create an ipv4 peer that only peers ipv6 and the other way around.
It also gets rid of "Multiprotocol" toggle which implies its some sort of special BGP option but it isn't.
It's now the same as here:
plugins/net/frr/src/opnsense/mvc/app/models/OPNsense/Quagga/BGP.xml
Line 397 in 03a4c64
Related issue
Fixes: #5647