net/frr: move peer group policy into address families - #5646
Open
Monviech wants to merge 1 commit into
Open
Conversation
Peer groups gained an explicit address family selector, but only the activation command was rendered inside the selected address-family block. Policy-related settings such as prefix-lists, route-maps, next-hop-self and default-originate were still emitted in the global peer group section. This caused IPv6-only peer groups to be activated under IPv6 while their policy configuration was generated outside of the IPv6 address-family context, where it would not apply as expected. Move these AF-scoped peer group settings into the address-family loop and keep only session-level settings in the global peer group block. Add small helpers for prefix-list and route-map attachment rendering so the same logic can be shared between normal neighbors and peer groups.
Member
Author
|
Asked for feedback here: But I also tested the change myself and it looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important notices
Before you submit a pull request, we ask you kindly to acknowledge the following:
If AI was used, please disclose:
Describe the problem
Peer groups gained an explicit address family selector, but only the activation command was rendered inside the selected address-family block. Policy-related settings such as prefix-lists, route-maps, next-hop-self and default-originate were still emitted in the global peer group section.
This caused IPv6-only peer groups to be activated under IPv6 while their policy configuration was generated outside of the IPv6 address-family context, where it would not apply as expected.
Move these AF-scoped peer group settings into the address-family loop and keep only session-level settings in the global peer group block. Add small helpers for prefix-list and route-map attachment rendering so the same logic can be shared between normal neighbors and peer groups.
Fixes: #5506