ddclient: skip deprecated ipv6#5253
Open
gewuerz-gurke wants to merge 2 commits intoopnsense:masterfrom
Open
Conversation
skip deprecated ipv6 to avoid being stuck to an old address
fichtner
reviewed
Feb 24, 2026
| if line.startswith('\tinet'): | ||
| parts = line.split() | ||
| if (parts[0] == 'inet' and service == 'if') or (parts[0] == 'inet6' and service == 'if6'): | ||
| if (parts[0] == 'inet' and service == 'if') or (parts[0] == 'inet6' and service == 'if6' and 'deprecated' not in line): |
Member
There was a problem hiding this comment.
skipping works as long as there is another address that's not deprecated. Although it's supposed to not be used in some cases it's the best address there is.
Author
There was a problem hiding this comment.
so you mean keep a deprecated address as long as there is no valid address?
Author
|
updated that a deprecated address is returned in case no valid is found. Hope it is OK that it is the last deprecated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
With "check ip method" it is possible that the interface address is set to deprecated. Currently it is possible that a ip address change is not recognized. Because the deprecated ip is the same as last ip. This delays the ip update till the deprecated entry is removed after the valid time.
Solution:
add check that the line does not contain deprecated