nat/npt: Refactor network prefix translation view #9504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monviech
changed the title
Monviech
added
cleanup
…llowed and there is no inversion allowed
fichtner
reviewed
Dec 8, 2025
| $filter_funct = function ($record) use ($category) { | ||
| return empty($category) || array_intersect(explode(',', $record->categories), $category); | ||
| /* categories are indexed by name in the record, but offered as uuid in the selector */ | ||
| $catids = !empty((string)$record->categories) ? explode(',', (string)$record->categories) : []; |
Member
There was a problem hiding this comment.
string? :D explode? :D
getValues()
fichtner
reviewed
Dec 8, 2025
| return empty($category) || array_intersect(explode(',', $record->categories), $category); | ||
| /* categories are indexed by name in the record, but offered as uuid in the selector */ | ||
| $catids = !empty((string)$record->categories) ? explode(',', (string)$record->categories) : []; | ||
| return empty($category) || array_intersect($catids, $category); |
Member
There was a problem hiding this comment.
if you cast to array please use count()
Member
Author
There was a problem hiding this comment.
Can I fix this in a separate PR, because the same pattern is used in 3 or 4 other controllers.
fichtner
reviewed
Dec 8, 2025
| foreach ($results['rows'] as &$record) { | ||
| /* offer list of colors to be used by the frontend */ | ||
| $record['category_colors'] = $this->getCategoryColors( | ||
| !empty($record['categories']) ? explode(',', $record['categories']) : [] |
Member
There was a problem hiding this comment.
why are we getting array keys here instead of objects? these constructs handling multi value conversions are not good as they bloat the controller code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses two methods (toggle log and move rule) that I generalized into base helper methods in this PR: #9492