Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update password really only when needed with update_password=always + support for password_hash #81

Merged
merged 2 commits into from
Jul 6, 2022

Conversation

bartowl
Copy link

@bartowl bartowl commented Oct 8, 2021

This PR fixes #79 by:

  • added support to interpret password as hash instead of plaintext in dbpasswords by setting users[*].password_is_hash=true
  • implemented check for password change for hashes
  • implemented check for plaintext password against S: pw hash
  • fixes a bug where double quotes were used in IDENTIFIED BY VALUES (oracle requires single quotes here)
  • revert to module defaults for update_password parameter

@Rendanic
Copy link
Member

Please split the PR in 2 commits. We need a dedicated commit from oracle_user for ansible-oracle-modules. Otherwise we cannot backport the commit to the original repository.

@Rendanic Rendanic added the bug Something isn't working label Oct 12, 2021
@bartowl bartowl force-pushed the bugfix/issue_79 branch 2 times, most recently from 0fcb8bd to 2177def Compare October 15, 2021 07:30
bartowl added 2 commits July 6, 2022 11:34
- implemented check for password change for hashes
- implemented check for plaintext password against S: pw hash
  dbpasswords by setting users[*].password_is_hash=true
- revert to module defaults for update_password parameter
@bartowl bartowl force-pushed the bugfix/issue_79 branch from 2177def to a54814b Compare July 6, 2022 09:40
@Rendanic Rendanic merged commit d62a078 into opitzconsulting:oc Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oracle_user does not check if password needs to be updated
2 participants