bugfix: host_fs_layout needed disk even if configure_host_disks==false #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartowl
force-pushed
the
bugfix/host_fs_layout
branch
2 times, most recently
from
300bcd1 to
1b66fca
Compare
bartowl
force-pushed
the
bugfix/host_fs_layout
branch
from
1b66fca to
6ea5775
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to just set configure_host_disks false and still be able to chown/chmod mountpoints specified by filesystem attributes in host_fs_layout without the need of adding empty array "disks" attribute there, to satisfy with_subelements task (that would be ignored anyway by configure_host_disks in when condition).