Skip to content

Conversation

0xdfgp
Copy link

@0xdfgp 0xdfgp commented Jan 8, 2019

Following the official documentation, the date-time format accepts:

  • "1970-01-01T10:05:08"
  • "1970-01-01T10:05:08.10"
  • "1970-01-01T10:05:08+01:00"

There is an issue with the DateTime format. The regex is actually invalid because the offset is not optional.

This pull request includes:

  • Fix to accept date times without offset
  • Unitary tests for date-time (there is nothing now)

@sorinsarca sorinsarca merged commit cc89e90 into opis:master Jan 9, 2019
@0xdfgp
Copy link
Author

0xdfgp commented Jan 12, 2019

@sorinsarca thanks for merging the fix. Could you add a new release in order to update our dependencies with composer, please?

@sorinsarca
Copy link
Member

@ISD4N version 1.0.12 was just released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants