Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/38766 additional project permissions #9779

Merged
merged 29 commits into from
Nov 2, 2021
Merged

Feature/38766 additional project permissions #9779

merged 29 commits into from
Nov 2, 2021

Conversation

ulferts
Copy link
Contributor

@ulferts ulferts commented Oct 26, 2021 •
edited
Loading

Introduces separate permissions for various aspects of administrating a project.

https://community.openproject.org/wp/38766

TODO

  • Reenable manage_types
  • Check select_project_modules and move methods to ModulesController
  • Check manage_versions
  • Introduce permission for managing custom fields
  • Check manage_categories
  • Check manage_repositories
  • Check manage_project_activities
  • Introduce permission for managing backlogs
  • Migration to assign added permissions to members having the edit_project permission
  • Adapt seed data No need to adapt them since the project admin receives all the permissions
  • Adapt permissions referenced in the work package representer for selecting the custom fields active in a project

@ulferts
turn the manage_types permission authoritative
40f7989 
This will for the time being break the other project settings permissions
@ulferts
remove unused method
b11b648 
The form is now rendered in angular
@ulferts ulferts force-pushed the feature/38766-additional-project-permissions branch 3 times, most recently from 01550d1 to a5d6e74 Compare October 27, 2021 13:59
@ulferts ulferts force-pushed the feature/38766-additional-project-permissions branch from a5d6e74 to 8400780 Compare October 27, 2021 16:30
@ulferts ulferts force-pushed the feature/38766-additional-project-permissions branch 2 times, most recently from f37317d to 5ed4eb5 Compare October 28, 2021 08:14
@ulferts ulferts force-pushed the feature/38766-additional-project-permissions branch from 5ed4eb5 to d8587fc Compare October 28, 2021 10:29
@ulferts ulferts force-pushed the feature/38766-additional-project-permissions branch from d8587fc to 83cdefa Compare October 28, 2021 11:28
@ulferts ulferts force-pushed the feature/38766-additional-project-permissions branch from 7c9bdea to af7fd1d Compare October 28, 2021 14:11
@ulferts ulferts force-pushed the feature/38766-additional-project-permissions branch 4 times, most recently from 77e8fd8 to c88c664 Compare October 29, 2021 12:50
@ulferts ulferts force-pushed the feature/38766-additional-project-permissions branch 2 times, most recently from 5114202 to 69f08f4 Compare November 1, 2021 14:27
@ulferts ulferts force-pushed the feature/38766-additional-project-permissions branch from 69f08f4 to 5882a82 Compare November 1, 2021 14:56
@ulferts ulferts marked this pull request as draft November 1, 2021 15:21
@ulferts ulferts force-pushed the feature/38766-additional-project-permissions branch from ce3bf9a to 7040d2b Compare November 2, 2021 10:02
@ulferts ulferts marked this pull request as ready for review November 2, 2021 12:54
oliverguenther
oliverguenther approved these changes Nov 2, 2021
View reviewed changes
Copy link
Member

@oliverguenther oliverguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works as expected!

@oliverguenther oliverguenther merged commit b5bffe0 into dev Nov 2, 2021
@oliverguenther oliverguenther deleted the feature/38766-additional-project-permissions branch November 2, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverguenther oliverguenther oliverguenther approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ulferts @oliverguenther