[36467] Add API users form and schema endpoints#9090
Merged
Conversation
fd99aa3 to
969eecb
Compare
969eecb to
a18dc13
Compare
a18dc13 to
01d4cf7
Compare
bcb534a to
1edabd7
Compare
1edabd7 to
6e56bd9
Compare
ulferts
requested changes
Mar 17, 2021
Contributor
There was a problem hiding this comment.
Apart from what I noted down in code, these are the things I noted when using the API
- The
nameproperty is not described in the schema -
firstNameandlastNameare described as non writable - The
passwordproperty is described although it does not exist on the user resource - Attributes turn up in the form's payload although they are not writable (e.g.
name):
The name property is not accessible directly for users
Member
Author
The password property is a write-only property so it's not contained in the payload. It can still be set and written as per the schema |
Member
Author
|
@ulferts I believe addressed all remarks |
1d3c395 to
b1b9591
Compare
8ecca64 to
c3edd40
Compare
ulferts
approved these changes
Mar 23, 2021
Contributor
ulferts
left a comment
There was a problem hiding this comment.
👍
Thanks for fixing the user API description along the way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Attribute conversion fixes
firstName and lastName of user were not correctly converted to the frontend. That resulted in
validationErrorsproperties containing the backend keysfirstnameandlastname. This has been fixed.Representable nil patch
A patch is added for representable to fix trailblazer/representable#234, since
Setteris not being applied when the input is nil.https://community.openproject.com/work_packages/36467