[60133] Saving a new WP triggers browser warning message #17547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocus on elements, but we dont need to show confirmation after creating it
…er-warning-message
…t form component, so we just check the conditions if the current element is in the dom, not for other available instances
…er-warning-message
oliverguenther
approved these changes
Jan 13, 2025
oliverguenther
deleted the
60133-saving-a-new-wp-triggers-browser-warning-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/60133
What are you trying to accomplish?
Fix showing browser confirmation while creating a WP.
Screenshots
Screen.Recording.2025-01-07.at.16.30.13.mov
What approach did you choose and why?
Check if it is in creating mode, skip showing the confirmation dialog.
Merge checklist