[#55480] Fix Include subprojects return wrong total sum #16383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oliverguenther |
oliverguenther
force-pushed
the
fix/include_subprojects_num
branch
from
f05523c
to
54b8303
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Fix bug OP#55480 Project and Include subprojects return wrong total sum values (button 'Include projects')
Ticket
https://community.openproject.org/work_packages/55480
I have changed the numberOfProjectsInFilter$. When this.includeSubprojects is true, it collects all subproject hrefs and updates the number.
Screencast.from.2024-08-09.15-48-28.webm
If this method is not considered best practice, please let me know.
I am doing my best to improve it.