Skip to content

Bug fix:'operator-sdk add crd' doesn't work after add kubebuilder tags #1660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
estroz merged 5 commits into from
Aug 9, 2019
Merged

Bug fix:'operator-sdk add crd' doesn't work after add kubebuilder tags #1660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4c8c1c8
fix bug: 'operator-sdk add crd' doesn't work after add kubebuilder ta…
xm2 Jul 10, 2019
4ee8bc9
Merge remote-tracking branch 'upstream/master'
xm2 Jul 15, 2019
5ec432f
add fix info to changelog
xm2 Jul 16, 2019
fb665c0
Update CHANGELOG.md
xm2 Jul 17, 2019
9a929b7
Merge remote-tracking branch 'upstream/master'
xm2 Aug 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
### Removed

### Bug Fixes
- Configure the repo path correctly in `operator-sdk add crd` and prevent the command from running outside of an operator project. ([#1660](https://github.com/operator-framework/operator-sdk/pull/1660))

## v0.10.0

Expand Down
3 changes: 3 additions & 0 deletions cmd/operator-sdk/add/crd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,11 @@ Generated CR filename: <project-name>/deploy/crds/<group>_<version>_<kind>_cr.y
}

func crdFunc(cmd *cobra.Command, args []string) error {
projutil.MustInProjectRoot()

cfg := &input.Config{
AbsProjectPath: projutil.MustGetwd(),
Repo: projutil.GetGoPkg(),
}
if len(args) != 0 {
return fmt.Errorf("command %s doesn't accept any arguments", cmd.CommandPath())
Expand Down