Skip to content

Add option to disable OCI image build #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
baijum wants to merge 1 commit into from
Closed

Add option to disable OCI image build #1600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions cmd/operator-sdk/build/cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ var (
imageBuildArgs string
imageBuilder string
goBuildArgs string
goWithoutImage bool
)

func NewCmd() *cobra.Command {
Expand All @@ -56,6 +57,7 @@ For example:
buildCmd.Flags().StringVar(&imageBuildArgs, "image-build-args", "", "Extra image build arguments as one string such as \"--build-arg https_proxy=$https_proxy\"")
buildCmd.Flags().StringVar(&imageBuilder, "image-builder", "docker", "Tool to build OCI images. One of: [docker, podman, buildah]")
buildCmd.Flags().StringVar(&goBuildArgs, "go-build-args", "", "Extra Go build arguments as one string such as \"-ldflags -X=main.xyz=abc\"")
buildCmd.Flags().BoolVar(&goWithoutImage, "without-image", false, "Do not build OCI image.")
return buildCmd
}

Expand Down Expand Up @@ -83,8 +85,8 @@ func createBuildCommand(imageBuilder, context, dockerFile, image string, imageBu
}

func buildFunc(cmd *cobra.Command, args []string) error {
if len(args) != 1 {
return fmt.Errorf("command %s requires exactly one argument", cmd.CommandPath())
if len(args) != 1 && !goWithoutImage {
return fmt.Errorf("command %s requires exactly one argument (if there is no '--without-image' flag)", cmd.CommandPath())
}

projutil.MustInProjectRoot()
Expand Down Expand Up @@ -118,6 +120,9 @@ func buildFunc(cmd *cobra.Command, args []string) error {
if err := projutil.GoBuild(opts); err != nil {
return fmt.Errorf("failed to build operator binary: (%v)", err)
}
if goWithoutImage {
return nil
}
}

image := args[0]
Expand Down