cmd/operator-sdk/build: expand env in go build#1535
Merged
estroz merged 3 commits intooperator-framework:masterfrom Jun 7, 2019
Merged
cmd/operator-sdk/build: expand env in go build#1535estroz merged 3 commits intooperator-framework:masterfrom
estroz merged 3 commits intooperator-framework:masterfrom
Conversation
internal/util/projutil: always append os.Environ() to go cmds
openshift-ci-robot
added
the
size/XS
joelanford
approved these changes
Jun 7, 2019
Member
joelanford
left a comment
joelanford
left a comment
There was a problem hiding this comment.
LGTM. We should add a line in the CHANGELOG since this fixes a bug.
hasbro17
reviewed
Jun 7, 2019
Co-Authored-By: Haseeb Tariq <hasbro17@gmail.com>
AlexNPavel
approved these changes
Jun 7, 2019
estroz
pushed a commit
to estroz/operator-sdk
that referenced
this pull request
Jul 19, 2019
* cmd/operator-sdk/build: expand env in go build * internal/util/projutil: always append os.Environ() to go cmds * CHANGELOG.md: add bug fix for env expansion in operator-sdk build Co-Authored-By: Haseeb Tariq <hasbro17@gmail.com>
estroz
pushed a commit
that referenced
this pull request
Jul 19, 2019
* cmd/operator-sdk/build: expand env in go build * internal/util/projutil: always append os.Environ() to go cmds * CHANGELOG.md: add bug fix for env expansion in operator-sdk build Co-Authored-By: Haseeb Tariq <hasbro17@gmail.com>
joel-bluedata
pushed a commit
to joel-bluedata/kubedirector
that referenced
this pull request
Feb 11, 2020
This removes $GOPATH from the beginning of the filepaths built into the object, and e.g. shown in stacktraces. The operator-sdk build is supposed to do this as well, although with our version of the operator SDK you need to backport this fix to your own local copy before building/installing it: operator-framework/operator-sdk#1535
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change: expand environment variables in
operator-sdk build'sgo buildprocess, and always append os.Environ() togocommands.Motivation for the change:
exec.Cmd's are not run in a shell, so env variables are not expanded.Closes #1530