cmd/operator-sdk/build/cmd.go: support podman#1488
Merged
joelanford merged 2 commits intooperator-framework:masterfrom May 28, 2019
Merged
cmd/operator-sdk/build/cmd.go: support podman#1488joelanford merged 2 commits intooperator-framework:masterfrom
joelanford merged 2 commits intooperator-framework:masterfrom
Conversation
openshift-ci-robot
added
the
size/XS
hasbro17
approved these changes
May 24, 2019
Contributor
hasbro17
left a comment
hasbro17
left a comment
There was a problem hiding this comment.
LGTM
Do we need to mention this in the CHANGELOG?
The cl-reference doc would need updating for the podman option.
https://github.com/operator-framework/operator-sdk/blob/master/doc/sdk-cli-reference.md#flags
lilic
suggested changes
May 27, 2019
Member
lilic
left a comment
lilic
left a comment
There was a problem hiding this comment.
We should maybe add it to the CHANGELOG but also mention it in the docs somewhere?
https://github.com/operator-framework/operator-sdk#prerequisites add it to the prerequisites list, which version onwards we support.
Otherwise lgtm thanks!
openshift-ci-robot
added
size/S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Adds support for running
podmanduringoperator-sdk buildMotivation for the change:
See #1207