cmd: allow CGO_ENABLED=1

[jnodorp]

stop overriding CGO_ENABLED on build

Fixes #1404

[openshift-ci-robot]

Hi @jschlichtholz. Thanks for your PR.

I'm waiting for a operator-framework or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[AlexNPavel]

Can you add a check if cgo is not set before the environment setup line for the command? By default, cgo is enabled on macOS and Linux, but this breaks cross-compilation for us (for instance, building on Fedora may link to C-libraries that don't exist in UBI, which is CentOS 7 based). You can use os.LookupEnv and use the second return argument (which is a bool) to figure out if it is set. If it is not set, we should add CGO_ENABLED=0 to make sure cross-compilation works. If it set, leave it unchanged.

[jnodorp]

Thanks @AlexNPavel! I updated the PR according to you comment.

[lilic]

/ok-to-test

[AlexNPavel]

LGTM

[lilic]

The ansible e2e test failed so I restarted the job.

lgtm on green, thanks!

[joelanford]

LGTM