Skip to content

cmd/operator-sdk/up/local.go: sdk up local build by package than only the main file#1357

Merged
hasbro17 merged 1 commit intooperator-framework:masterfrom
chechiachang:up-local-build-by-package
Apr 30, 2019
Merged

cmd/operator-sdk/up/local.go: sdk up local build by package than only the main file#1357
hasbro17 merged 1 commit intooperator-framework:masterfrom
chechiachang:up-local-build-by-package

Conversation

@chechiachang
Copy link
Contributor

@chechiachang chechiachang commented Apr 29, 2019

Description of the change:

Description of the change: The current sdk up local only build main.go. It would be better to build by cmd/manager/ pacakge.

Motivation for the change:

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 29, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 29, 2019

Hi @chechiachang. Thanks for your PR.

I'm waiting for a operator-framework or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 29, 2019
lilic
lilic suggested changes Apr 29, 2019
View reviewed changes
@chechiachang chechiachang force-pushed the up-local-build-by-package branch from 260113a to 7fe512f Compare April 29, 2019 09:41
@chechiachang
cmd/operator-sdk/up/local.go: sdk up local should build by manager pa…
4cc8d21 
…ckage instead of main.go file only

Description of the change: The current sdk up local only build main.go. It would be better to build by cmd/manager/ pacakge.
@chechiachang chechiachang force-pushed the up-local-build-by-package branch from 7fe512f to 4cc8d21 Compare April 29, 2019 16:21
@lilic
Copy link
Member

lilic commented Apr 30, 2019

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 30, 2019
lilic
lilic approved these changes Apr 30, 2019
View reviewed changes
Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

joelanford
joelanford approved these changes Apr 30, 2019
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hasbro17
hasbro17 approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@hasbro17 hasbro17 merged commit ef5a723 into operator-framework:master Apr 30, 2019
@chechiachang chechiachang deleted the up-local-build-by-package branch May 1, 2019 05:01
estroz pushed a commit to estroz/operator-sdk that referenced this pull request May 2, 2019
@chechiachang @estroz
cmd/operator-sdk/up/local.go: sdk up local should build by manager pa…
1f5310b 
…ckage instead of main.go file only (operator-framework#1357)

Description of the change: The current sdk up local only build main.go. It would be better to build by cmd/manager/ pacakge.
@joelanford joelanford mentioned this pull request Jun 28, 2019
Closed
@hasbro17 hasbro17 mentioned this pull request Jul 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joelanford joelanford joelanford approved these changes

+2 more reviewers

@lilic lilic lilic approved these changes

@hasbro17 hasbro17 hasbro17 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chechiachang @openshift-ci-robot @lilic @joelanford @hasbro17