cmd/.../genutil: verbose codegen by default#1271
Merged
estroz merged 3 commits intooperator-framework:masterfrom Apr 2, 2019
Merged
cmd/.../genutil: verbose codegen by default#1271estroz merged 3 commits intooperator-framework:masterfrom
estroz merged 3 commits intooperator-framework:masterfrom
Conversation
test/e2e: remove explicit setting of verbosity
openshift-ci-robot
added
the
size/M
hasbro17
approved these changes
Apr 1, 2019
Contributor
|
Nit: Update the CHANGELOG as well. It's a minor fix but worth pointing out. |
joelanford
approved these changes
Apr 1, 2019
Member
joelanford
left a comment
joelanford
left a comment
There was a problem hiding this comment.
LGTM after CHANGELOG update
Contributor
|
Also can you backport this to the v0.6.x branch. Not sure if this warrants a v0.6.1 release but we should try to make sure we port our bug fixes back to the latest release branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1181
Description of the change: instead of checking whether
GOFLAGS="-v"is set, always print codegen errors.Motivation for the change: better user experience.