Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use none driver without sudo in upstream minikube e2e tests #572

Merged

Conversation

exdx
Copy link
Member

@exdx exdx commented Jan 29, 2021

Description of the change:
Similar to operator-framework/operator-lifecycle-manager#1983, we started seeing failures in the minikube e2e tests after the underlying ubuntu-latest VM image used in github actions changed from ubuntu 18 to 20.

It seems like using minikube config set vm-driver none is no longer being respected, minikube used the docker driver instead and complained about sudo mode. This change is to use the none vm driver for and not require sudo for running minikube. Based on kubernetes/minikube#3760 this seems to work now and will be supported.

Motivation for the change:
Regression

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@benluddy
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, exdx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 29, 2021

@exdx: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws 8bd48ed link /test e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #572 (3753249) into master (16422cd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #572   +/-   ##
=======================================
  Coverage   49.49%   49.49%           
=======================================
  Files          91       91           
  Lines        6302     6302           
=======================================
  Hits         3119     3119           
  Misses       2492     2492           
  Partials      691      691           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16422cd...f88bcb4. Read the comment docs.

@exdx exdx changed the title fix: use docker driver in upstream minikube e2e tests fix: use none driver without sudo in upstream minikube e2e tests Feb 1, 2021
@kevinrizza
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2021
@kevinrizza kevinrizza merged commit 6183dbb into operator-framework:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants