Skip to content

Conversation

@tmshort
Copy link
Contributor

@tmshort tmshort commented Aug 15, 2023

Fixes path join issue

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Fixes path join issue

Signed-off-by: Todd Short <todd.short@me.com>
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #1136 (73e4301) into master (dba1e10) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1136   +/-   ##
=======================================
  Coverage   53.79%   53.79%           
=======================================
  Files         108      108           
  Lines       10166    10166           
=======================================
  Hits         5469     5469           
  Misses       3736     3736           
  Partials      961      961           

Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2023
@openshift-merge-robot openshift-merge-robot merged commit 7f37952 into operator-framework:master Aug 15, 2023
@tmshort tmshort deleted the go-restful branch August 16, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants