fix(manifests): add singleton operatorhub cr - #468
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njhale The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
| @@ -0,0 +1,11 @@ | |||
| apiVersion: config.openshift.io/v1 | |||
There was a problem hiding this comment.
We want a filename that sorts after 0000_03_config-operator_01_operatorhub.crd.yaml (which is what's currently vendored) and 0000_03_marketplace-operator_01_operatorhub.crd.yaml (where openshift/api#1178 is taking the CRD). Maybe 0000_03_marketplace-operator_02_operatorhub.cr.yaml?
c3470e6 to
a91a99f
Compare
- Relocate the singleton OperatorHub CR instance from openshift/cluster-config-operator - add the marketplace capability annotatation to CR instance This consolidates ownership of OperatorHub-related manifests to the marketplace-operator and will help prevent issues with resource application order. Signed-off-by: Nick Hale <njohnhale@gmail.com>
a91a99f to
c2a6e95
Compare
njhale
changed the title
| apiVersion: config.openshift.io/v1 | ||
| kind: OperatorHub | ||
| metadata: | ||
| name: cluster |
There was a problem hiding this comment.
@wking confirmed that CVO won't have a problem with the (temporary) duplicate in openshift/cluster-config-operator. The PR to remove that is also queued up for after this merges: openshift/cluster-config-operator#245
|
/lgtm |
|
@njhale: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
5 participants
This consolidates ownership of OperatorHub-related manifests to the marketplace-operator
and will help prevent issues with resource application order.
Signed-off-by: Nick Hale njohnhale@gmail.com