Skip to content

Conversation

grokspawn
Copy link
Contributor

Description of the change:
Adopt the same tolerances as the base catalog-operator which generates these jobs, so that the bundle-unpacker is tolerant to taints identically to OLM control-plane elements.

Motivation for the change:
Incompatible taints on worker nodes could prevent bundle unpack jobs dispatching, when this is a core control plane element of OLMv0.

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

Signed-off-by: grokspawn <jordan@nimblewidget.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 7, 2025
Copy link

openshift-ci bot commented Jul 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Signed-off-by: grokspawn <jordan@nimblewidget.com>
@grokspawn grokspawn marked this pull request as ready for review July 8, 2025 02:38
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2025
@openshift-ci openshift-ci bot requested review from dtfranz and oceanc80 July 8, 2025 02:38
@grokspawn grokspawn changed the title add catalog-operator control-plane-specific tolerations to unpack jobs 🐛 add catalog-operator control-plane-specific tolerations to unpack jobs Jul 8, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2025
@oceanc80
Copy link
Contributor

oceanc80 commented Jul 8, 2025

/lgtm

@grokspawn grokspawn added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2025
Copy link

openshift-ci bot commented Jul 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: oceanc80

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 57e6b8c into operator-framework:master Jul 8, 2025
14 checks passed
@grokspawn grokspawn deleted the unpacker-control-plane-tolerations branch July 8, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants