add missing pod disruption reasons to isPodDead #3519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isPodDead had checks for TerminationByKubelet and DeletionByTaintManager. It was missing checks for PreemptionByScheduler EvictionByEvictionAPI DeletionByPodGC ref: https://kubernetes.io/docs/concepts/workloads/pods/disruptions/#pod-disruption-conditions This PR adds those reasons. Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>
anik120
force-pushed
the
missing-pod-disruption-reasons
branch
from
30b952c to
507a962
Compare
perdasilva
approved these changes
Feb 22, 2025
perdasilva
reviewed
Feb 22, 2025
Merged
via the queue into
operator-framework:master
with commit Feb 25, 2025
59bfe7f
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isPodDead had checks for TerminationByKubelet and DeletionByTaintManager. It was missing checks for
PreemptionByScheduler
EvictionByEvictionAPI
DeletionByPodGC
ref: https://kubernetes.io/docs/concepts/workloads/pods/disruptions/#pod-disruption-conditions
This PR adds those reasons.
Description of the change:
Motivation for the change:
Architectural changes:
Testing remarks:
Reviewer Checklist
/doc[FLAKE]are truly flaky and have an issue