Skip to content

Conversation

joelanford
Copy link
Member

Description of the change:

Re-adds a run-local target to the Makefile what was lost in the refactoring we've done to align this repo with others in the Operator Framework org.

Motivation for the change:

To give developers and contributors a really simple on-ramp for running a cluster locally based on the code they have currently checked out.

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@grokspawn grokspawn requested a review from perdasilva December 5, 2024 20:42
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2024
@grokspawn grokspawn added this pull request to the merge queue Jan 7, 2025
@grokspawn grokspawn removed this pull request from the merge queue due to a manual request Jan 7, 2025
@grokspawn grokspawn added this pull request to the merge queue Jan 7, 2025
Merged via the queue into operator-framework:master with commit 45559bd Jan 7, 2025
12 checks passed
@joelanford joelanford deleted the run-local branch June 11, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants