Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set correct groupName tag for packages.operators.coreos.com #3406

Merged
merged 2 commits into from
Nov 11, 2024
Merged

fix: set correct groupName tag for packages.operators.coreos.com #3406

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7539192
fix: set correct groupName tag for packages.operators.coreos.com
manusa Oct 2, 2024
b4e0390
chore: update generated code
manusa Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: set correct groupName tag for packages.operators.coreos.com 
Seems like the groupName tag is not correct for the packagemanifest_types
located in both pkg/package-server/api/operators and
pkg/package-server/api/operators/v1

Both register.go files do point to the correct package name
  • Loading branch information
@manusa
manusa committed Oct 2, 2024
commit 7539192fbf96cd38a343a706fbbc3aa729488c4b
2 changes: 1 addition & 1 deletion pkg/package-server/apis/operators/doc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// +k8s:deepcopy-gen=package

// Package operators is the internal version of the API.
// +groupName=operators.coreos.com
// +groupName=packages.operators.coreos.com
package operators
2 changes: 1 addition & 1 deletion pkg/package-server/apis/operators/v1/doc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
// +k8s:defaulter-gen=TypeMeta
// +k8s:openapi-gen=true

// +groupName=operators.coreos.com
// +groupName=packages.operators.coreos.com
package v1
Loading