[OCPBUGS-34173]: fix sorting unpack jobs #3299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitathomas
force-pushed
the
unpack-job-sort
branch
from
1953a07 to
c7ab8fa
Compare
kevinrizza
reviewed
May 31, 2024
| } | ||
| if condJ == nil { | ||
| return true | ||
| } |
There was a problem hiding this comment.
is there a test case we can add to this somehow?
There was a problem hiding this comment.
There was a problem hiding this comment.
Test cases here should check for this now: ankitathomas#1
ankitathomas
changed the title
Signed-off-by: Ankita Thomas <ankithom@redhat.com>
Signed-off-by: Catherine Chan-Tse <cchantse@redhat.com>
Signed-off-by: Ankita Thomas <ankithom@redhat.com>
ankitathomas
force-pushed
the
unpack-job-sort
branch
from
e250c63 to
5fe4295
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.