Skip to content

Conversation

perdasilva
Copy link
Collaborator

Signed-off-by: perdasilva perdasilva@redhat.com

Description of the change:
This PR moves the deprecated e2e tests to one namespace per spec

Motivation for the change:
e2e stability

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky
  • Tests that remove the [FLAKE] tag are no longer flaky

@openshift-ci
Copy link

openshift-ci bot commented Mar 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2022
@perdasilva perdasilva force-pushed the refactor_deprecated_e2e branch from 230a1c8 to a6dc5d7 Compare March 25, 2022 16:28
@perdasilva
Copy link
Collaborator Author

@akihikokuroda @timflannagan I've addressed the comments =D

@akihikokuroda
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2022
@perdasilva perdasilva force-pushed the refactor_deprecated_e2e branch from a6dc5d7 to 2bcbe88 Compare March 25, 2022 17:09
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 25, 2022

New changes are detected. LGTM label has been removed.

Signed-off-by: perdasilva <perdasilva@redhat.com>
@timflannagan timflannagan force-pushed the refactor_deprecated_e2e branch from 2bcbe88 to 40cad88 Compare March 25, 2022 17:12
@perdasilva perdasilva added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2022
@openshift-merge-robot openshift-merge-robot merged commit b3a3ca2 into operator-framework:master Mar 25, 2022
nsapse pushed a commit to nsapse/operator-lifecycle-manager that referenced this pull request Mar 28, 2022
Signed-off-by: perdasilva <perdasilva@redhat.com>
Signed-off-by: Noah Sapse <nsapse@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants