Update extractMessage #2268
Merged
Update extractMessage #2268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
awgreene
force-pushed
the
big-performance-improvement
branch
from
b26c176 to
8f53300
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anik120, awgreene The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
awgreene
force-pushed
the
big-performance-improvement
branch
from
8f53300 to
bba0d3e
Compare
|
/lgtm |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
awgreene
force-pushed
the
big-performance-improvement
branch
from
bba0d3e to
acfb87e
Compare
anik120
reviewed
Jul 19, 2021
Whe building the subscription condition message, check if the status of the InstallPlan is available before iterating through bundle lookup conditions. Also update string returned to include spaces between multiple messages. Signed-off-by: Alexander Greene <greene.al1991@gmail.com>
awgreene
force-pushed
the
big-performance-improvement
branch
from
acfb87e to
804875c
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the subscription condition message,
check if the status of the InstallPlan is available
before iterating through bundle lookup conditions.