feat: add uninstall makefile target #1438
Conversation
|
/test e2e-aws-console-olm |
|
/test e2e-aws-olm |
1 similar comment
|
/test e2e-aws-olm |
|
/test images |
|
/test e2e-aws-olm |
|
/test e2e-gcp-upgrade |
openshift-ci-robot
added
needs-rebase
|
Hi @ecordell, WDYT? Could we move with it now? |
There was a problem hiding this comment.
@camilamacedo86 Thanks again for submitting this!
Mainly, I feel we should separate process decisions -- in the docs -- from other, more objective, changes (uninstall rule).
CONTRIBUTING.md
Outdated
| @@ -0,0 +1,69 @@ | |||
| # How to contribute | |||
There was a problem hiding this comment.
This was moved for: https://github.com/operator-framework/operator-lifecycle-manager/pull/1438/files
camilamacedo86
changed the title
|
/test images |
1 similar comment
|
/test images |
|
/test e2e-gcp |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
Hi @njhale, Really tks for the help. I have no permissions to merge here. So, feel free to do it when/if possible. |
|
Merges to this repo are automated with tide, so as soon as master opens up
this should merge.
…On Thu, May 7, 2020 at 6:22 AM Camila Macedo ***@***.***> wrote:
Hi @njhale <https://github.com/njhale>,
Really tks for the help. I have no permissions to merge here. So, feel
free to do it when/if possible.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1438 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA73QLQ7WZNVFZJKR4HUIQ3RQKDU3ANCNFSM4MF5TVWQ>
.
|
|
/retest Please review the full test history for this PR and help us cut down flakes. |
28 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Description of the change:
The changes made in #898 rebased with the master. The #898 was closed because got outdated. However, users have to ping it telling that it was very helpful and why it was not merged. So, I think that may still have a good value.
Closes: #789