install.sh does not work if you have never installed OLM before

[jmazzitelli]

I'm looking to install OLM in a fresh new minikube. I go to the operatorhub.io page and it tells me to run install.sh to install OLM:

I run that and it does nothing. Silently exits with no messages, no errors, no nothing:

$ curl -sL https://github.com/operator-framework/operator-lifecycle-manager/releases/download/v0.18.2/install.sh | bash -s v0.18.2
$ 

The problem is this: https://github.com/operator-framework/operator-lifecycle-manager/blob/v0.18.2/scripts/install.sh#L17-L18

kubectl get deployment olm-operator -n openshift-operator-lifecycle-manager -o=jsonpath='{.spec}' > /dev/null 2>&1
...

That silently exits the script because of the set -e on line 6.

Suggest you either remove line 6 or refactor that kubectl call + if-stmt so it doesn't abort on non-0 exit code (which is what you typically will expect here because someone running this most likely doesn't have OLM yet).

[timflannagan]

Another user was running into this problem in d7eead7.

[jmazzitelli]

I think this will fix it:

$ diff /tmp/olm-install.sh.ORIG /tmp/olm-install.sh
17,18c17
< kubectl get deployment olm-operator -n openshift-operator-lifecycle-manager -o=jsonpath='{.spec}' > /dev/null 2>&1
< if [[ $? -eq 0 ]]; then
---
> if kubectl get deployment olm-operator -n openshift-operator-lifecycle-manager -o=jsonpath='{.spec}' > /dev/null 2>&1; then

[jmazzitelli]

That script is doing something now that I fixed it as I describe above:

$ /tmp/olm-install.sh v0.18.2
customresourcedefinition.apiextensions.k8s.io/catalogsources.operators.coreos.com created
customresourcedefinition.apiextensions.k8s.io/clusterserviceversions.operators.coreos.com created
customresourcedefinition.apiextensions.k8s.io/installplans.operators.coreos.com created
customresourcedefinition.apiextensions.k8s.io/operatorconditions.operators.coreos.com created
customresourcedefinition.apiextensions.k8s.io/operatorgroups.operators.coreos.com created
customresourcedefinition.apiextensions.k8s.io/operators.operators.coreos.com created
customresourcedefinition.apiextensions.k8s.io/subscriptions.operators.coreos.com created
customresourcedefinition.apiextensions.k8s.io/catalogsources.operators.coreos.com condition met
customresourcedefinition.apiextensions.k8s.io/clusterserviceversions.operators.coreos.com condition met
customresourcedefinition.apiextensions.k8s.io/installplans.operators.coreos.com condition met
customresourcedefinition.apiextensions.k8s.io/operatorconditions.operators.coreos.com condition met
customresourcedefinition.apiextensions.k8s.io/operatorgroups.operators.coreos.com condition met
customresourcedefinition.apiextensions.k8s.io/operators.operators.coreos.com condition met
customresourcedefinition.apiextensions.k8s.io/subscriptions.operators.coreos.com condition met
namespace/olm created
namespace/operators created
serviceaccount/olm-operator-serviceaccount created
clusterrole.rbac.authorization.k8s.io/system:controller:operator-lifecycle-manager created
clusterrolebinding.rbac.authorization.k8s.io/olm-operator-binding-olm created
deployment.apps/olm-operator created
deployment.apps/catalog-operator created
clusterrole.rbac.authorization.k8s.io/aggregate-olm-edit created
clusterrole.rbac.authorization.k8s.io/aggregate-olm-view created
operatorgroup.operators.coreos.com/global-operators created
operatorgroup.operators.coreos.com/olm-operators created
clusterserviceversion.operators.coreos.com/packageserver created
catalogsource.operators.coreos.com/operatorhubio-catalog created
Waiting for deployment "olm-operator" rollout to finish: 0 of 1 updated replicas are available...
deployment "olm-operator" successfully rolled out
deployment "catalog-operator" successfully rolled out
Package server phase: Installing
Package server phase: Succeeded
Waiting for deployment "packageserver" rollout to finish: 1 of 2 updated replicas are available...
deployment "packageserver" successfully rolled out

[timflannagan]

@jmazzitelli SGTM - do you want to open a PR that fixes this script?

[jmazzitelli]

PR: #2211

[jmazzitelli]

Until that PR is merged and released, the workaround would be to just use sed to strip the set -e command (see command below). Just means if one of the other commands fails, the script will keep going, but, oh well. For now, good enough.

curl -sL https://github.com/operator-framework/operator-lifecycle-manager/releases/download/v0.18.2/install.sh | sed 's/set -e//g' | bash -s v0.18.2