⚠ bump rukpak to v0.16.0

[joelanford]

Description

Bumping rukpak dependency to v0.16.0. This includes changes to the way that rukpak names Bundle objects derived from BundleDeployments and the way that performs registry+v1 to plain conversion. This results in different names and labels for some objects, so it may be a breaking change for some users.

Reviewer Checklist

• API Go Documentation
• Tests: Unit Tests (and E2E Tests, if appropriate)
• Comprehensive Commit Messages
• Links to related GitHub Issue(s)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b13e55c) 83.72% compared to head (af1e4d5) 83.68%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #555      +/-   ##
==========================================
- Coverage   83.72%   83.68%   -0.05%     
==========================================
  Files          20       20              
  Lines         811      809       -2     
==========================================
- Hits          679      677       -2     
  Misses         91       91              
  Partials       41       41              

Flag	Coverage Δ
e2e	63.53% <ø> (-0.09%)	⬇️
unit	78.75% <ø> (+0.20%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[m1kola]

This results in different names and labels for some objects, so it may be a breaking change for some users.

Trying to understand this a bit better. Is bumping rukpak in operator-controller causing breaking changes? Or deploying a new version of rukpak into the cluster? I suspect it is the latter.

[joelanford]

There are no breaking changes to the Operator API in this PR.

However, if there are existing Operator objects in a cluster with existing BundleDeployment objects, the names and labels of Bundles, Roles, RoleBindings, ClusterRoles, and ClusterRoleBindings will change, which will cause the rukpak provisioner recreate those objects with their new names/labels to account for those changes.

If anyone is depending on the old names or labels (they really shouldn't be since they include a hash value that changes as the BD template changes), they'll be broken.