Skip to content

Conversation

@joelanford
Copy link
Member

Description

Closes #334

This doesn't actually change any code in operator-controller to use the CatalogMetadata API. It just updates catalogd to populate objects with this API (while still populating the Package and BundleMetadata APIs).

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford joelanford requested a review from a team as a code owner August 15, 2023 21:06
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #336 (073f55f) into main (4eba8f3) will decrease coverage by 0.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
- Coverage   82.84%   82.62%   -0.23%     
==========================================
  Files          21       21              
  Lines         892      892              
==========================================
- Hits          739      737       -2     
- Misses        107      108       +1     
- Partials       46       47       +1     
Flag Coverage Δ
e2e 62.44% <ø> (-0.23%) ⬇️
unit 78.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@joelanford
Copy link
Member Author

This codecov coverage decrease makes me think we've got some non-determinism somewhere.

I'm wondering if we're getting a conflict on update sometimes during the e2e. So sometimes there's an error here, and sometimes there isn't.

@m1kola
Copy link
Member

m1kola commented Aug 17, 2023

@joelanford I merged dependabot's PR which does the same and only after that noticed your PR. Sorry about this.

I'll close this as it is no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make catalogd's CatalogMetadata APIs available for operator-controller

2 participants