🐛 OPRUN-4217: OwnNamespace default handling

[perdasilva]

Description

Currently, if a bundle only supports OwnNamespace the watchNamespace configuration will no be present for that bundle and the bundle will be automatically installed in OwnNamespace mode (by setting the targetNamespaces to the install namespace). While this is intuitive and makes life easier for the user, it can can lead to a break in default behavior if the package decided to add AllNamespaces support. For instance:

v1 only supports OwnNamespace install mode. The ClusterExtension has no configuration so the bundle is installed in OwnNamespace mode.

v1.1 adds AllNamespaces support and the ClusterExtension detects the upgrade and initiates it. The default is now AllNamespaces mode. So, the operator is now installed in AllNamespace mode without knowledge or acceptance by the user.

To address this issue, we modify the defaulting and configuration behavior for this case by requiring watchNamespace to be set and removing the defaulting behavior, i.e. making it undefined. I.e. only bundles with AllNamespaces mode can be installed without watchNamespace configuration. This means that when v2 comes out with AllNamespaces support, the configuration will already be present in the ClusterExtension and v2 will be installed in the same mode. The user can then remove the configuration if they wish to change install modes.

So, in this PR, we:

• Add some additional unit tests around watchNamespaces being null/empty (this is not exactly related but was identified while writing this PR)
• Modify the configuration validation to ensure that watchNamespaces is required when OwnNamespace is the only supported install mode (we include MultiNamespaces in the tests for completeness but this install mode will never be supported)
• Modify the defaulting behavior in the reg+v1 renderer to ensure no defaults are set for bundles that don't support AllNamespaces install mode
• Add ExtensionConfigBytes() method to ClusterExtension to easily grab user configuration
• Update UnmarshalConfig to treat nil as {} to force schema validation (catch missing required values, etc.)
• Update RegistryV1ManifestProvider tests to ensure bundle configuration is being properly validated
• Add single-namespace- and own-namespace-operator fixtures and update e2e tests to check for bad configuration as well as good

Reviewer Checklist

• API Go Documentation
• Tests: Unit Tests (and E2E Tests, if appropriate)
• Comprehensive Commit Messages
• Links to related GitHub Issue(s)

[netlify]

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	f995320
🔍 Latest deploy log	https://app.netlify.com/projects/olmv1/deploys/68fa7e750d7f9f0008072ff6
😎 Deploy Preview	https://deploy-preview-2283--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.28%. Comparing base (3a6afed) to head (f995320).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2283      +/-   ##
==========================================
+ Coverage   71.19%   71.28%   +0.09%     
==========================================
  Files          90       90              
  Lines        6995     7003       +8     
==========================================
+ Hits         4980     4992      +12     
+ Misses       1601     1599       -2     
+ Partials      414      412       -2     

Flag	Coverage Δ
e2e	45.88% <7.69%> (-0.03%)	⬇️
experimental-e2e	14.70% <0.00%> (+0.09%)	⬆️
unit	58.87% <100.00%> (+0.07%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull Request Overview

This PR addresses an issue where bundles with only OwnNamespace support could automatically change install modes during upgrades when AllNamespaces support was added. The fix requires explicit watchNamespace configuration for bundles without AllNamespaces support, preventing unexpected mode changes during upgrades.

Key changes:

• Modified configuration validation to require watchNamespace when AllNamespaces is not supported
• Removed defaulting behavior for OwnNamespace-only bundles in the renderer
• Enhanced test coverage for null/empty watchNamespace configurations

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
internal/operator-controller/rukpak/bundle/config.go	Updated validation logic to require watchNamespace for non-AllNamespaces bundles and changed nil config handling
internal/operator-controller/rukpak/render/render.go	Removed automatic defaulting to install namespace for OwnNamespace-only bundles
internal/operator-controller/applier/provider.go	Updated to use new ExtensionConfigBytes() method and apply validation for all SingleOwnNamespace cases
api/v1/clusterextension_types.go	Added ExtensionConfigBytes() helper method to retrieve user configuration
test/experimental-e2e/single_namespace_support_test.go	Added comprehensive e2e tests for SingleNamespace and OwnNamespace install modes with configuration validation
internal/operator-controller/rukpak/render/render_test.go	Added unit tests covering default target namespace behavior for various install mode combinations
internal/operator-controller/rukpak/bundle/config_test.go	Expanded tests for null/missing watchNamespace configurations and validation errors
testdata/images/bundles/*	Added fixtures for single-namespace-operator and own-namespace-operator test bundles
testdata/images/catalogs/test-catalog/v1/configs/catalog.yaml	Added catalog entries for new test operators

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated no new comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[perdasilva]

Just because of the new method added to the public API (exported). I think we should move it out of the API package. → https://github.com/operator-framework/operator-controller/pull/2283/files#r2456565041

I've removed that and made it a private utility closer to where it is used

[camilamacedo86]

It seems solid for me, LGTM

[tmshort]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment