-
Couldn't load subscription status.
- Fork 68
🌱 Add internal direct bundle install support #2252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
🌱 Add internal direct bundle install support #2252
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
53d52c9 to
15594cc
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2252 +/- ##
==========================================
+ Coverage 70.41% 70.83% +0.41%
==========================================
Files 90 91 +1
Lines 8794 7035 -1759
==========================================
- Hits 6192 4983 -1209
+ Misses 2189 1636 -553
- Partials 413 416 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
15594cc to
fb36b11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 For now it seems reasonable
/lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fb36b11 to
28f3498
Compare
|
New changes are detected. LGTM label has been removed. |
e85efd0 to
2c0d54a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would great to add at least some unit tests and great if we can have an e2e test demonstrating the usage.
100% - the idea here though was to have something quick and dirty to aid us in playing around with the status stuff without having to deal with catalogs. There will definitely need to be tests of all kinds before this ever becomes user facing. Right now it shouldn't be on the critical path of other PRs. If it breaks, that's ok. |
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> Signed-off-by: Per G. da Silva <pegoncal@redhat.com>
2c0d54a to
6f34900
Compare
Description
Adds annotation driven internal bundle install for internal purposes (at least for now) to aid in the testing / validation of extension and revision status development
P.S. this is not meant for user consumption (at least not yet) and I'm avoiding making API changes to not pollute the downstream techpreview API and possibly creating confusion
Reviewer Checklist