Skip to content

🌱 Use metadata to determine namespace in args #2072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025
Merged

🌱 Use metadata to determine namespace in args #2072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion config/base/catalogd/manager/manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,12 @@ spec:
args:
- --leader-elect
- --metrics-bind-address=:7443
- --external-address=catalogd-service.olmv1-system.svc
- --external-address=catalogd-service.$(POD_NAMESPACE).svc
env:
- name: POD_NAMESPACE
valueFrom:
fieldRef:
fieldPath: metadata.namespace
image: controller:latest
name: manager
volumeMounts:
Expand Down
6 changes: 5 additions & 1 deletion manifests/experimental-e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1595,7 +1595,7 @@ spec:
- args:
- --leader-elect
- --metrics-bind-address=:7443
- --external-address=catalogd-service.olmv1-system.svc
- --external-address=catalogd-service.$(POD_NAMESPACE).svc
- --feature-gates=APIV1MetasHandler=true
- --tls-cert=/var/certs/tls.crt
- --tls-key=/var/certs/tls.key
Expand All @@ -1605,6 +1605,10 @@ spec:
env:
- name: GOCOVERDIR
value: /e2e-coverage
- name: POD_NAMESPACE
valueFrom:
fieldRef:
fieldPath: metadata.namespace
image: quay.io/operator-framework/catalogd:devel
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down
7 changes: 6 additions & 1 deletion manifests/experimental.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1572,13 +1572,18 @@ spec:
- args:
- --leader-elect
- --metrics-bind-address=:7443
- --external-address=catalogd-service.olmv1-system.svc
- --external-address=catalogd-service.$(POD_NAMESPACE).svc
- --feature-gates=APIV1MetasHandler=true
- --tls-cert=/var/certs/tls.crt
- --tls-key=/var/certs/tls.key
- --pull-cas-dir=/var/ca-certs
command:
- ./catalogd
env:
- name: POD_NAMESPACE
valueFrom:
fieldRef:
fieldPath: metadata.namespace
image: quay.io/operator-framework/catalogd:devel
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down
6 changes: 5 additions & 1 deletion manifests/standard-e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1588,7 +1588,7 @@ spec:
- args:
- --leader-elect
- --metrics-bind-address=:7443
- --external-address=catalogd-service.olmv1-system.svc
- --external-address=catalogd-service.$(POD_NAMESPACE).svc
- --tls-cert=/var/certs/tls.crt
- --tls-key=/var/certs/tls.key
- --pull-cas-dir=/var/ca-certs
Expand All @@ -1597,6 +1597,10 @@ spec:
env:
- name: GOCOVERDIR
value: /e2e-coverage
- name: POD_NAMESPACE
valueFrom:
fieldRef:
fieldPath: metadata.namespace
image: quay.io/operator-framework/catalogd:devel
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down
7 changes: 6 additions & 1 deletion manifests/standard.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1565,12 +1565,17 @@ spec:
- args:
- --leader-elect
- --metrics-bind-address=:7443
- --external-address=catalogd-service.olmv1-system.svc
- --external-address=catalogd-service.$(POD_NAMESPACE).svc
- --tls-cert=/var/certs/tls.crt
- --tls-key=/var/certs/tls.key
- --pull-cas-dir=/var/ca-certs
command:
- ./catalogd
env:
- name: POD_NAMESPACE
valueFrom:
fieldRef:
fieldPath: metadata.namespace
image: quay.io/operator-framework/catalogd:devel
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down
Loading