✨ Use a separate namespace for each e2e test #1428
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1428 +/- ##
==========================================
- Coverage 73.42% 73.26% -0.17%
==========================================
Files 42 42
Lines 3063 3063
==========================================
- Hits 2249 2244 -5
- Misses 641 644 +3
- Partials 173 175 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I have encountered one failure over the course of several dozen; so this is not perfect, but it does reduce the likelyhood |
tmshort
force-pushed
the
fix-e2e-flakes
branch
2 times, most recently
from
ae21f27
to
d940463
Compare
Fixes operator-framework#1307 Create and use a new namespace for every e2e test. This means that extension resources are placed in their own namespace. The tests deletes the namespace, and then waits until completion. This ensures that _most_ of an extension's resources are deleted. It does guarantee that global resources (e.g. CRDs, CRs, CRBs) are deleted. And would eventually allow the tests to be run in parallel (assuming the installed extensions allow for that). Signed-off-by: Todd Short <tshort@redhat.com>
tmshort
force-pushed
the
fix-e2e-flakes
branch
from
d940463
to
7b79ace
Compare
|
Of course, it failed e2e... but it failed because the bundle's CRDs were still present... not much we can do here except chase a timeout, which is never a good idea. This was the interesting condition on the CRDs: |
Fixes #1307
Create and use a new namespace for every e2e test. This means that extension resources are placed in their own namespace. The tests deletes the namespace, and then waits until completion. This ensures that most of an extension's resources are deleted.
It does guarantee that global resources (e.g. CRDs, CRs, CRBs) are deleted.
And would eventually allow the tests to be run in parallel (assuming the installed extensions allow for that).
Description
Reviewer Checklist