Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Fix a typo in the catalogs installation step #1411

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

itroyano
Copy link
Contributor

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@itroyano itroyano requested a review from a team as a code owner October 28, 2024 06:50
Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 64d9617
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/671f34447f31b40008ee7dcf
😎 Deploy Preview https://deploy-preview-1411--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.57%. Comparing base (07ed131) to head (64d9617).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1411   +/-   ##
=======================================
  Coverage   73.57%   73.57%           
=======================================
  Files          42       42           
  Lines        3194     3194           
=======================================
  Hits         2350     2350           
  Misses        659      659           
  Partials      185      185           
Flag Coverage Δ
e2e 55.13% <ø> (ø)
unit 53.38% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@m1kola m1kola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ❤️ Bash: it worked fine with these two commas

@m1kola m1kola added this pull request to the merge queue Oct 28, 2024
Merged via the queue into operator-framework:main with commit dd7898e Oct 28, 2024
17 checks passed
@itroyano itroyano deleted the patch-1 branch October 28, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants