Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Flakes: replace require with assert in retry funcs #1330

Merged
merged 1 commit into from
Oct 3, 2024
Merged

🌱 Flakes: replace require with assert in retry funcs #1330

merged 1 commit into from
Oct 3, 2024

Commits on Oct 3, 2024

  1. Replace require with assert in retry funcs 

    When `require` assertions are not satisfied they fails
a test immediately. This is not desired when used
with retry function such as `EventuallyWithT` since
they are supposed to retry on a failure.

This can cause flakes when, for example, we are asserting
on a resource condition. On the first hit the resource might
not have a condition and `require` will fail `EventuallyWithT`
despite the fact that the code is correct and the condition
gets set eventually.

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
    @m1kola
    m1kola committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    4af861e View commit details
    Browse the repository at this point in the history