Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 dynamicsource: fix race condition with wait and valid scheme #1323

Conversation

joelanford
Copy link
Member

Also decreasing 1 second poll interval to 100ms. The HasSynced check that repeats every interval simply locks mutexes and checks variables available in memory, so it is extremely fast and has low over head. This decreased the test's average time from >1000ms to ~250ms

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford joelanford requested a review from a team as a code owner October 1, 2024 00:39
Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit f21a225
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66fb44c03170720008ae7404
😎 Deploy Preview https://deploy-preview-1323--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.99%. Comparing base (9125118) to head (f21a225).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1323   +/-   ##
=======================================
  Coverage   75.99%   75.99%           
=======================================
  Files          41       41           
  Lines        2429     2429           
=======================================
  Hits         1846     1846           
  Misses        410      410           
  Partials      173      173           
Flag Coverage Δ
e2e 58.25% <100.00%> (ø)
unit 53.02% <100.00%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2024
@LalatenduMohanty LalatenduMohanty added this pull request to the merge queue Oct 1, 2024
Merged via the queue into operator-framework:main with commit f14bca4 Oct 1, 2024
18 checks passed
@joelanford joelanford deleted the fix-dynamicsource-start-test branch October 22, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants