🐛 main.go: improve logging for configuration of global auth #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
everettraven
previously approved these changes
Sep 26, 2024
4 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1316 +/- ##
==========================================
+ Coverage 76.07% 76.09% +0.02%
==========================================
Files 40 40
Lines 2378 2380 +2
==========================================
+ Hits 1809 1811 +2
Misses 401 401
Partials 168 168
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LalatenduMohanty
requested changes
Sep 26, 2024
cmd/manager/main.go
Outdated
| return "" | ||
| } | ||
| if err != nil { | ||
| logger.Error(err, "could not stat auth file path", "path", authFilePath) | ||
| logger.Error(err, "unable to stat auth file path", "path", authFilePath) |
There was a problem hiding this comment.
unable to stat auth file path is kind of meaning less in a way. How would the user know that we are talking about os.stat and what does that mean.
|
/hold as the existing lgtm would lead to merging of the PR and I have a review comment #1316 (comment) which should be addressed. |
openshift-ci
bot
added
the
do-not-merge/hold
LalatenduMohanty
removed this pull request from the merge queue due to a manual request
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
joelanford
dismissed stale reviews from everettraven and tmshort
via
0513d61
joelanford
force-pushed
the
auth-file-path-logging
branch
from
cee5d55
to
0513d61
Compare
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
Merged
via the queue into
operator-framework:main
with commit Sep 27, 2024
360f892
17 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reviewer Checklist