Modify Operator Conditions #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
joelanford
reviewed
Feb 21, 2023
joelanford
reviewed
Feb 21, 2023
joelanford
reviewed
Feb 21, 2023
varshaprasad96
force-pushed
the
conditions/follow-ups
branch
from
abd898f to
6725a0e
Compare
|
Could you please rebase @varshaprasad96 - I can override the go-apidiff. |
This PR brings in 2 changes: 1. Introduce a new reason for Unknown status: Currently, we specify BundleDeploymentFailure or InstallationSuccess as reasons for an unknown status. This means that we are not sure if the install is successfull or we aren't sure of a failure either. To make it more accurate, we introduce a new reason "InstallStatusUnknown" to mean that the status cannot be determined at that particular instant. 2. Rename "BundleDeploymentFailed" to "InstallationUnsuccessful" This prevents leaking of Rukpak API names. BundleDeployment Failed can be one of the reason for unsuccessful installation. Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
varshaprasad96
force-pushed
the
conditions/follow-ups
branch
from
6725a0e to
741b5eb
Compare
|
New changes are detected. LGTM label has been removed. |
|
@perdasilva done! Thanks :) |
|
/override go-apidiff |
|
@perdasilva: Overrode contexts on behalf of perdasilva: go-apidiff In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings in 2 changes:
Introduce a new reason for Unknown status: Currently, we specify BundleDeploymentFailure or InstallationSuccess as reasons for an unknown status. This means that we are not sure if the install is successfull or we aren't sure of a failure either. To make it more accurate, we introduce a new reason "InstallStatusUnknown" to mean that the status cannot be determined at that particular instant.
Rename "BundleDeploymentFailed" to "InstallationUnsuccessful": This prevents leaking of Rukpak API names. BundleDeployment Failed can be one of the reason for unsuccessful installation.