-
Notifications
You must be signed in to change notification settings - Fork 66
🌱 Add CI to check if golang version updated #1264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
name: go-verdiff | ||
on: | ||
pull_request: | ||
paths: | ||
- '**.mod' | ||
branches: | ||
- main | ||
jobs: | ||
go-verdiff: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 0 | ||
- name: Check golang version | ||
run: hack/tools/check-go-version.sh "${{ github.event.pull_request.base.sha }}" |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
#!/bin/bash | ||
|
||
BASE_REF=${1:-main} | ||
GO_VER=$(sed -En 's/^go (.*)$/\1/p' "go.mod") | ||
OLDIFS="${IFS}" | ||
IFS='.' MAX_VER=(${GO_VER}) | ||
IFS="${OLDIFS}" | ||
|
||
if [ ${#MAX_VER[*]} -ne 3 -a ${#MAX_VER[*]} -ne 2 ]; then | ||
echo "Invalid go version: ${GO_VER}" | ||
exit 1 | ||
fi | ||
|
||
GO_MAJOR=${MAX_VER[0]} | ||
GO_MINOR=${MAX_VER[1]} | ||
GO_PATCH=${MAX_VER[2]} | ||
|
||
RETCODE=0 | ||
|
||
check_version () { | ||
local whole=$1 | ||
local file=$2 | ||
OLDIFS="${IFS}" | ||
IFS='.' ver=(${whole}) | ||
IFS="${OLDIFS}" | ||
|
||
if [ ${ver[0]} -gt ${GO_MAJOR} ]; then | ||
echo "${file}: ${whole}: Bad golang version (expected ${GO_VER} or less)" | ||
return 1 | ||
fi | ||
if [ ${ver[1]} -gt ${GO_MINOR} ]; then | ||
echo "${file}: ${whole}: Bad golang version (expected ${GO_VER} or less)" | ||
return 1 | ||
fi | ||
|
||
if [ ${#ver[*]} -eq 2 ] ; then | ||
return 0 | ||
fi | ||
if [ ${#ver[*]} -ne 3 ] ; then | ||
echo "${file}: ${whole}: Badly formatted golang version" | ||
return 1 | ||
fi | ||
|
||
if [ ${ver[1]} -eq ${GO_MINOR} -a ${ver[2]} -gt ${GO_PATCH} ]; then | ||
echo "${file}: ${whole}: Bad golang version (expected ${GO_VER} or less)" | ||
return 1 | ||
fi | ||
return 0 | ||
} | ||
|
||
echo "Found golang version: ${GO_VER}" | ||
|
||
for f in $(find . -name "*.mod"); do | ||
v=$(sed -En 's/^go (.*)$/\1/p' ${f}) | ||
if [ -z ${v} ]; then | ||
echo "${f}: Skipping, no version found" | ||
continue | ||
fi | ||
if ! check_version ${v} ${f}; then | ||
RETCODE=1 | ||
fi | ||
old=$(git grep -ohP '^go .*$' "${BASE_REF}" -- "${f}") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This regex stipulates ONE space after "go"... (beware of fragile regex's) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually it stipulates one space after "go", then ANYTHING, including spaces. Since we're not "capturing" the version separately, it doesn't matter. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's managed by |
||
old=${old#go } | ||
new=$(git grep -ohP '^go .*$' "${f}") | ||
new=${new#go } | ||
if [ "${new}" != "${old}" ]; then | ||
echo "${f}: ${v}: Updated golang version from ${old}" | ||
RETCODE=1 | ||
fi | ||
done | ||
|
||
exit ${RETCODE} |
Uh oh!
There was an error while loading. Please reload this page.