-
Couldn't load subscription status.
- Fork 68
Introduce Pull Request Template #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4be9d9b to
06ef21b
Compare
06ef21b to
9d3ee67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
9d3ee67 to
1ae2597
Compare
17b7e4a to
9c07990
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good pending what others think about the discussion of a single line item for testing vs separate ones for unit/e2e.
I stated my preference for a single line item, but it isn't a strong preference or objectively better. So I'm good either way.
/lgtm
9c07990 to
50100ac
Compare
d1ec604 to
e095e45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
e095e45 to
82b158a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: Alexander Greene <greene.al1991@gmail.com>
42cc657 to
74ae265
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: Alexander Greene greene.al1991@gmail.com