fixup unit test description #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmshort
reviewed
Jan 25, 2023
internal/util/logging.go
Outdated
| @@ -0,0 +1,27 @@ | |||
| package util | |||
There was a problem hiding this comment.
oh crap - nah that snuck in
There was a problem hiding this comment.
was also trying to think about logging then gave up - ty!
There was a problem hiding this comment.
Fixed! @tmshort sorry for that - and thank you for catching it!
Signed-off-by: perdasilva <perdasilva@redhat.com>
LalatenduMohanty
pushed a commit
to LalatenduMohanty/operator-controller
that referenced
this pull request
Dec 19, 2024
Signed-off-by: Catherine Chan-Tse <cchantse@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just addresses a comment in a previous PR where a unit test description was found to be mismatched
Signed-off-by: perdasilva perdasilva@redhat.com