Skip to content

Consider using k8s.io/apimachinery/pkg/util/sets instead of map of empty structs for sets #454

Closed
@m1kola

Description

@m1kola

It was proposed to switch from maps for empty structs such as this:

visited := map[deppy.Identifier]struct{}{}

to using k8s.io/apimachinery/pkg/util/sets for sets. Example:

sets.New[deppy.Identifier]()

Originally posted by @stevekuznetsov in #453 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions